Palamedes
Joined: 10 Oct 2005
Posts: 1
|
 Posted: Mon Oct 10, 2005 9:17 am Post subject: PHP Notice: Undefined Variables |
 |
|
Hello. Firstly, nice program.
I'm a professional PHP developer and I'm noticing some issues in your code. The most notable is the use of variables that aren't pre-defined.
The very first line of your admin script is this;
| Code: | | list($startYr,$startMo,$startDay) = explode("/",$startDate); |
As $startDate isn't defined it will throw a notice.
| Quote: | | PHP Notice: Undefined variable: startDate in C:\Inetpub\L10Apps\L10HC_Admin.php on line 13 |
Good php coding practices dictate that you either test for an unset variable (something like this);
| Code: | | list($startYr,$startMo,$startDay) = (is_array($startDate))?explode("/",$startDate):array('','',''); |
...or define it prior to using it so that such warnings can be avoided..
I keep my alerts set to throw on anything.. My server, as well as my current clients server, is very strict. I didn't set it this way, they did and I can tell you it's a large source of frustration in many instances but forces me to write good code..
This is something you need to fix, and would only take a few moments to trap for undefined variables.
There is no good reason to not trap for this sort of thing and will make your code base look that much better to those who can "read." 
Your admin.php script, while it works, returns the following notices:
PHP Notice: Undefined variable: startDate in C:\Inetpub\L10Apps\L10HC_Admin.php on line 13
PHP Notice: Undefined offset: 2 in C:\Inetpub\L10Apps\L10HC_Admin.php on line 13
PHP Notice: Undefined offset: 1 in C:\Inetpub\L10Apps\L10HC_Admin.php on line 13
PHP Notice: Undefined variable: API in C:\Inetpub\L10Apps\L10HC_Admin.php on line 15
PHP Notice: Undefined index: action in C:\Inetpub\L10Apps\L10HC_Admin.php on line 16
PHP Notice: Undefined index: action in C:\Inetpub\L10Apps\L10HC_Admin.php on line 18
PHP Notice: Undefined index: acct in C:\Inetpub\L10Apps\L10HC_Admin.php on line 21
PHP Notice: Undefined variable: dataDir in C:\Inetpub\L10Apps\L10HC_Admin.php on line 26
PHP Notice: Undefined variable: curYr4 in C:\Inetpub\L10Apps\L10_LIB.php on line 23
PHP Notice: Undefined offset: 1 in C:\Inetpub\L10Apps\L10_LIB.php on line 282
PHP Notice: Undefined offset: 1 in C:\Inetpub\L10Apps\L10_LIB.php on line 282
PHP Notice: Undefined offset: 1 in C:\Inetpub\L10Apps\L10_LIB.php on line 282
PHP Notice: Undefined offset: 1 in C:\Inetpub\L10Apps\L10_LIB.php on line 282
PHP Notice: Undefined offset: 1 in C:\Inetpub\L10Apps\L10_LIB.php on line 282
PHP Notice: Undefined variable: dbTest in C:\Inetpub\L10Apps\L10_LIB_DB.php on line 12
PHP Notice: Undefined index: L10HC. in C:\Inetpub\L10Apps\L10HC_LIB.php on line 22
PHP Notice: Undefined index: L10HC_PW in C:\Inetpub\L10Apps\L10HC_Admin.php on line 56
PHP Notice: Undefined variable: acctManager in C:\Inetpub\L10Apps\L10HC_Admin.php on line 445
PHP Notice: Undefined index: pw in C:\Inetpub\L10Apps\L10HC_Admin.php on line 462
PHP Notice: Undefined index: pw in C:\Inetpub\L10Apps\L10HC_Admin.php on line 462
PHP Notice: Undefined variable: acctManager in C:\Inetpub\L10Apps\L10HC_Admin.php on line 445
PHP Notice: Undefined index: pw in C:\Inetpub\L10Apps\L10HC_Admin.php on line 462
PHP Notice: Undefined index: pw in C:\Inetpub\L10Apps\L10HC_Admin.php on line 462 |
|
FAQ
Search
Memberlist
Usergroups
Register
Profile
Log in to check your private messages
Log in
